Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectrogram example notebook #181

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

SundarRajan28
Copy link
Contributor

  • Adding an example notebook for audio processing with spectrogram augmentation

Copy link
Contributor

@LakshmiKumar23 LakshmiKumar23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SundarRajan28 I am seeing a failure in the build stage for this notebook example:

Verify graph failed
[ERR]  {rocalVerify}  Invalid layout
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
Cell In[13], [line 1](vscode-notebook-cell:?execution_count=13&line=1)
----> [1](vscode-notebook-cell:?execution_count=13&line=1) audio_pipeline.build()
      [2](vscode-notebook-cell:?execution_count=13&line=2) audioIteratorPipeline = ROCALAudioIterator(audio_pipeline)

File /usr/local/lib/python3.10/dist-packages/amd/rocal/pipeline.py:133, in Pipeline.build(self)
    [131](https://vscode-remote+ssh-002dremote-002bkapu.vscode-resource.vscode-cdn.net/usr/local/lib/python3.10/dist-packages/amd/rocal/pipeline.py:131) if (status != types.OK):
    [132](https://vscode-remote+ssh-002dremote-002bkapu.vscode-resource.vscode-cdn.net/usr/local/lib/python3.10/dist-packages/amd/rocal/pipeline.py:132)     print("Verify graph failed")
--> [133](https://vscode-remote+ssh-002dremote-002bkapu.vscode-resource.vscode-cdn.net/usr/local/lib/python3.10/dist-packages/amd/rocal/pipeline.py:133)     exit(0)
    [134](https://vscode-remote+ssh-002dremote-002bkapu.vscode-resource.vscode-cdn.net/usr/local/lib/python3.10/dist-packages/amd/rocal/pipeline.py:134) return self

NameError: name 'exit' is not defined

@LakshmiKumar23
Copy link
Contributor

@SundarRajan28 also please add a readme to state pre reqs like librosa, matplotlib modules etc.

Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the review comments

@SundarRajan28
Copy link
Contributor Author

@LakshmiKumar23 Can you share how you are building the example notebook so that I can replicate the issue? I have not encountered this error.

@kiritigowda kiritigowda self-assigned this Jul 22, 2024
@kiritigowda kiritigowda added the enhancement New feature or request label Jul 22, 2024
@LakshmiKumar23
Copy link
Contributor

@LakshmiKumar23 Can you share how you are building the example notebook so that I can replicate the issue? I have not encountered this error.

@SundarRajan28 I am running it on my vscode

Copy link
Contributor

@rrawther rrawther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SundarRajan28 : Please address the review comments so we can merge this PR

@SundarRajan28
Copy link
Contributor Author

@rrawther I have resolved the review comments

@rrawther
Copy link
Contributor

@LakshmiKumar23: Can you please see if review comments are addressed and approve if it is ready to be merged

Copy link
Contributor

@LakshmiKumar23 LakshmiKumar23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrawther @kiritigowda this notebook has been tested with package install for rpp and mivisionx . Can be merged

@rrawther rrawther merged commit 64cd77d into ROCm:develop Aug 28, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants